dusk-network / plonk

Pure Rust implementation of the PLONK ZKProof System done by the Dusk team
https://dusk-network.github.io/plonk
Mozilla Public License 2.0
535 stars 148 forks source link

Turn `Composer` trait into a struct #803

Closed moCello closed 8 months ago

moCello commented 8 months ago

Resolves: #802

codecov[bot] commented 8 months ago

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (4b3568f) 85.63% compared to head (08dc0f6) 85.66%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dusk-network/plonk/pull/803/graphs/tree.svg?width=650&height=150&src=pr&token=7JKOJ0fLuy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network)](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) ```diff @@ Coverage Diff @@ ## master #803 +/- ## ========================================== + Coverage 85.63% 85.66% +0.03% ========================================== Files 57 57 Lines 4128 4095 -33 ========================================== - Hits 3535 3508 -27 + Misses 593 587 -6 ``` | [Files](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) | Coverage Δ | | |---|---|---| | [src/composer/compiler.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2NvbXBvc2VyL2NvbXBpbGVyLnJz) | `99.44% <100.00%> (ø)` | | | [src/composer/gate.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2NvbXBvc2VyL2dhdGUucnM=) | `0.00% <ø> (ø)` | | | [src/composer/prover.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2NvbXBvc2VyL3Byb3Zlci5ycw==) | `95.54% <100.00%> (ø)` | | | [src/composer/verifier.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2NvbXBvc2VyL3ZlcmlmaWVyLnJz) | `86.00% <100.00%> (ø)` | | | [src/constraint\_system/constraint.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2NvbnN0cmFpbnRfc3lzdGVtL2NvbnN0cmFpbnQucnM=) | `61.01% <ø> (-9.48%)` | :arrow_down: | | [src/proof\_system/proof.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL3Byb29mX3N5c3RlbS9wcm9vZi5ycw==) | `95.94% <ø> (ø)` | | | [src/runtime.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL3J1bnRpbWUucnM=) | `21.42% <ø> (+4.76%)` | :arrow_up: | | [tests/append\_gate.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-dGVzdHMvYXBwZW5kX2dhdGUucnM=) | `93.75% <100.00%> (ø)` | | | [tests/composer.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-dGVzdHMvY29tcG9zZXIucnM=) | `96.42% <100.00%> (+0.27%)` | :arrow_up: | | [tests/decomposition.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-dGVzdHMvZGVjb21wb3NpdGlvbi5ycw==) | `87.75% <100.00%> (-4.41%)` | :arrow_down: | | ... and [14 more](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Last update [4b3568f...08dc0f6](https://app.codecov.io/gh/dusk-network/plonk/pull/803?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network).