search

dusk-network / plonk

Pure Rust implementation of the PLONK ZKProof System done by the Dusk team
https://dusk-network.github.io/plonk
Mozilla Public License 2.0
535 stars 148 forks source link

Reduce hades constants from 960 to 335 #814

Closed moCello closed 6 months ago

moCello commented 6 months ago

Resolves #813

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c053660) 85.71% compared to head (bd762a1) 85.34%.

:exclamation: Current head bd762a1 differs from pull request most recent head cf2dcf3. Consider uploading reports for the commit cf2dcf3 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dusk-network/plonk/pull/814/graphs/tree.svg?width=650&height=150&src=pr&token=7JKOJ0fLuy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network)](https://app.codecov.io/gh/dusk-network/plonk/pull/814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) ```diff @@ Coverage Diff @@ ## master #814 +/- ## ========================================== - Coverage 85.71% 85.34% -0.37% ========================================== Files 57 57 Lines 4095 3686 -409 ========================================== - Hits 3510 3146 -364 + Misses 585 540 -45 ``` | [Files](https://app.codecov.io/gh/dusk-network/plonk/pull/814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) | Coverage Δ | | |---|---|---| | [src/composer/compress/hades.rs](https://app.codecov.io/gh/dusk-network/plonk/pull/814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2NvbXBvc2VyL2NvbXByZXNzL2hhZGVzLnJz) | `81.81% <ø> (ø)` | | ... and [51 files with indirect coverage changes](https://app.codecov.io/gh/dusk-network/plonk/pull/814/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/dusk-network/plonk/pull/814?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/dusk-network/plonk/pull/814?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Last update [c053660...cf2dcf3](https://app.codecov.io/gh/dusk-network/plonk/pull/814?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network).