dusk-network / rusk

Dusk's Smart Contract Platform
Mozilla Public License 2.0
129 stars 57 forks source link

Hide mnemonic by default during restore #1555

Open ascartabelli opened 3 months ago

ascartabelli commented 3 months ago

Summary

During the restore phase, which soon will be triggered when a mnemonic change is detected, we show the mnemonic we're about to restore.

We should consider the possibility of hiding it by default, and add a control to toggle its visibility, so that the user can confirm he's in a safe place where no one is looking at his screen.

ascartabelli commented 3 months ago

Also @laremas, while discussing this issue with @ZER0 we both agreed that the current design makes the eye follow columns, instead of rows.

Screenshot 2024-03-18 alle 09 32 12

Can you think about it? Only thing that comes to mind right now would be having alternating row colours, to force the eye to follow rows.

laremas commented 3 months ago

This is common for a lot of wallets, i would not make it similar to a table. I know that eyes follow columns (in our side of the world), but we are also showing the number of the words before them. Do we really wanna change this component?

ascartabelli commented 3 months ago

This is common for a lot of wallets, i would not make it similar to a table. I know that eyes follow columns (in our side of the world), but we are also showing the number of the words before them. Do we really wanna change this component?

It's not that we really want to change: was just a thing to consider as it came up.