search

dusk-network / rusk

The reference Dusk platform implementation and tools
Mozilla Public License 2.0
164 stars 60 forks source link

rusk-wallet: Make `wallet` a subcommand under Rusk #2142

Open HDauven opened 3 months ago

HDauven commented 3 months ago

Summary

Currently, if you install rusk-wallet, commands are called as follows:

rusk-wallet [COMMAND]

Given we want to move our CLI wallet into Rusk (see #2141), and the wallet is a subset of Rusk, it would be easier for users if they could call the wallet through Rusk directly, like this:

rusk wallet [COMMAND]

Possible solution design or implementation

Multiple approaches can be taken. We can opt to route commands from Rusk that target the wallet command directly to rusk-wallet itself. This should encompass non-interactive mode. The wallet lib will be imported into Rusk. This will not encompass interactive mode.

Daksh14 commented 2 months ago

I think its best we wait for the wallet-sdk for this to happen since this is just for convenience and not high priority, it should be fairly easy to add once its done