search

dusk-network / rusk

The reference Dusk platform implementation and tools
Mozilla Public License 2.0
161 stars 60 forks source link

consensus: Disable re-propagation of future Quorums #2171

Closed HDauven closed 2 weeks ago

HDauven commented 2 months ago

Summary

As discussed prior and as detailed in this advisory, we need to fix a potential memory leak.

Solution

The advisory provides multiple pathways forward.

fed-franz commented 2 months ago

As discussed, we are going to temporarily disable future-message repropagation.

The proper solution will be implemented in the future and includes:

autholykos commented 2 months ago

This has been deprioritized in favor of #2247

autholykos commented 3 weeks ago

This is missing handling future Quorums by checking that the provisioners in the attestation signatures are eligible. This needs discussion.

autholykos commented 3 weeks ago

The whole Quorum propagation should be seen as an optimization, and quorum messages are somewhat lower priorities wrt candidate blocks and votes. Because of this, and due to the difficulty in verifying quorum messages related to future rounds, this issue simply pertains to disabling future quorum re-propagation.

fed-franz commented 2 weeks ago

Implemented by #2717