Describe what is needed
A thorough review of the test suite related to the use of Schnorr in Rusk, including the implementation, proof generation and verification, serialization, and its utilization within the various circuits.
Describe why
There has been a collection of issues that took several trial/error to spot and fix. In particular, some of these issues were related to Schnorr (i.e. see #64). This decreased the confidence on the solidity of the library and its use throughout the stack. Therefore more tests would need to be added to eventually catch any other problematic situations that might arise.
Other context
This issue includes also opportunity for bettering/optmizing the scheme used, provided that it does not change the API
Describe what is needed A thorough review of the test suite related to the use of Schnorr in Rusk, including the implementation, proof generation and verification, serialization, and its utilization within the various circuits.
Describe why There has been a collection of issues that took several trial/error to spot and fix. In particular, some of these issues were related to Schnorr (i.e. see #64). This decreased the confidence on the solidity of the library and its use throughout the stack. Therefore more tests would need to be added to eventually catch any other problematic situations that might arise.
Other context This issue includes also opportunity for bettering/optmizing the scheme used, provided that it does not change the API