search

dusk-network / wallet-core

The library responsible for the core functionality of a wallet
Mozilla Public License 2.0
6 stars 9 forks source link

Change `fetch_notes` #71

Closed herr-seppia closed 1 year ago

herr-seppia commented 1 year ago

Instead of return a Vec<Note> the function now return a Vec<(Note,BlockHeight)> This is required by the wallet in order to implement the wallet history

See also dusk-network/wallet-cli#12

codecov-commenter commented 1 year ago

Codecov Report

Merging #71 (f9a278e) into main (17ab421) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/dusk-network/wallet-core/pull/71/graphs/tree.svg?width=650&height=150&src=pr&token=9W3J09AWZG&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network)](https://codecov.io/gh/dusk-network/wallet-core/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) ```diff @@ Coverage Diff @@ ## main #71 +/- ## ======================================= Coverage 63.53% 63.53% ======================================= Files 3 3 Lines 724 724 ======================================= Hits 460 460 Misses 264 264 ``` | [Impacted Files](https://codecov.io/gh/dusk-network/wallet-core/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) | Coverage Δ | | |---|---|---| | [src/lib.rs](https://codecov.io/gh/dusk-network/wallet-core/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2xpYi5ycw==) | `50.74% <ø> (ø)` | | | [src/imp.rs](https://codecov.io/gh/dusk-network/wallet-core/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2ltcC5ycw==) | `73.39% <100.00%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/dusk-network/wallet-core/pull/71?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/dusk-network/wallet-core/pull/71?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Last update [17ab421...f9a278e](https://codecov.io/gh/dusk-network/wallet-core/pull/71?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network).