search

dusk-network / wallet-core

The library responsible for the core functionality of a wallet
Mozilla Public License 2.0
6 stars 9 forks source link

Port the crate to the `piecrust`-enabled ABI #77

Closed ureeves closed 1 year ago

ureeves commented 1 year ago

This is a follow up on #74, using a version of rusk-abi that doesn't bring in piecrust in the dependency tree. We should likely rebase the previous PR's branch on top of this one, since it contains modifications required for the newest version of plonk.

Resolves #69 Resolves #70

codecov-commenter commented 1 year ago

Codecov Report

Merging #77 (4372562) into main (6d67f2b) will increase coverage by 9.58%. The diff coverage is 42.10%.

:exclamation: Current head 4372562 differs from pull request most recent head a04d877. Consider uploading reports for the commit a04d877 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dusk-network/wallet-core/pull/77/graphs/tree.svg?width=650&height=150&src=pr&token=9W3J09AWZG&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network)](https://app.codecov.io/gh/dusk-network/wallet-core/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) ```diff @@ Coverage Diff @@ ## main #77 +/- ## ========================================== + Coverage 63.53% 73.12% +9.58% ========================================== Files 3 3 Lines 724 573 -151 ========================================== - Hits 460 419 -41 + Misses 264 154 -110 ``` | [Impacted Files](https://app.codecov.io/gh/dusk-network/wallet-core/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) | Coverage Δ | | |---|---|---| | [src/imp.rs](https://app.codecov.io/gh/dusk-network/wallet-core/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2ltcC5ycw==) | `73.75% <0.00%> (+0.36%)` | :arrow_up: | | [src/lib.rs](https://app.codecov.io/gh/dusk-network/wallet-core/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL2xpYi5ycw==) | `46.57% <20.00%> (-4.18%)` | :arrow_down: | | [src/tx.rs](https://app.codecov.io/gh/dusk-network/wallet-core/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network#diff-c3JjL3R4LnJz) | `79.56% <47.61%> (+18.97%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/dusk-network/wallet-core/pull/77?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/dusk-network/wallet-core/pull/77?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Last update [6d67f2b...a04d877](https://app.codecov.io/gh/dusk-network/wallet-core/pull/77?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dusk-network).