search

dust-engine / dot_vox

Rust parser for MagicaVoxel .vox files.
MIT License
53 stars 20 forks source link

upgrade to nom 4 #14

Closed m4b closed 6 years ago

m4b commented 6 years ago

I am not familiar with nom at all, but upgrading to nom 4 will drop a lot of old transitive deps (many of which can't work with wasm targets); the major change in nom 4 appears to be IResult -> Result iiuc?

m4b commented 6 years ago

Here's a guide; again I don't understand much: https://github.com/Geal/nom/blob/master/doc/upgrading_to_nom_4.md

davidedmonds commented 6 years ago

Thanks for the issue - I had previously tried to upgrade to nom 4, but there were some changes to how Incomplete was working which prevented me at the time. I think these issues might have been resolved, so will have a go at migrating some time soon.

davidedmonds commented 6 years ago

Published v4.0.0 to crates.io, built with nom 4.1.

m4b commented 6 years ago

Wow that was fast, great work !