search

dusterio / laravel-plain-sqs

Custom SQS connector for Laravel (or Lumen) that supports third-party, plain JSON messages
MIT License
131 stars 93 forks source link

The signature of the constructor of the parent class has changed to v… #10

Closed nicolasroberge closed 7 years ago

nicolasroberge commented 7 years ago

I got this error when starting up artisan queue:work:

[2017-01-27 14:50:54] lumen.ERROR: exception 'ErrorException' with message 'Argument 3 passed to Illuminate\Queue\Jobs\SqsJob::__construct() must be of the type array, string given, called in /Users/nroberge/www/csdconstruction/services/lumen/vendor/dusterio/laravel-plain-sqs/src/Sqs/Queue.php on line 78 and defined' in /Users/nroberge/www/csdconstruction/services/lumen/vendor/illuminate/queue/Jobs/SqsJob.php:35 Stack trace:

0 /Users/nroberge/www/csdconstruction/services/lumen/vendor/illuminate/queue/Jobs/SqsJob.php(35): Laravel\Lumen\Application->Laravel\Lumen\Concerns{closure}(4096, 'Argument 3 pass...', '/Users/nroberge...', 35, Array)

The signature of the constructor of SqsJob wasn't the same as the parent class.

dusterio commented 7 years ago

Are you using Lumen 5.4?

nicolasroberge commented 7 years ago

Yes I am.

dusterio commented 7 years ago

Somebody else has notified me yesterday already that 5.4 isn't compatible - I will add an adapter shortly. If we simply change the signature - it may break 5.3- versions

dusterio commented 7 years ago

I made it conditional so that it doesn't break earlier versions