search

dusterio / laravel-plain-sqs

Custom SQS connector for Laravel (or Lumen) that supports third-party, plain JSON messages
MIT License
131 stars 93 forks source link

Broken on Lumen 5.4 from PR #16 #17

Closed jon-frankel closed 6 years ago

jon-frankel commented 6 years ago

PR #16 caused our installation of Lumen 5.4.7 to fail. The version string returned by $this->container->version() is "Lumen (5.4.7) (Laravel Components 5.4.*)". But if you do

>>> version_compare("Lumen (5.4.7) (Laravel Components 5.4.*)", '5.4')

this returns -1. So the update to this conditional doesn't work properly in this case. I'm currently reverting to the previous 0.1.8 tag.

dusterio commented 6 years ago

I'll revert back to regular expression instead of version_compare() shortly, thanks for reporting

dusterio commented 6 years ago

I'm tagging a new release, I brought back the regexp

jon-frankel commented 6 years ago

Thanks!