Open shawnm0705 opened 5 years ago
Issue: Queue names in sqs-plain.php is not detected. Always use 'default-handler' instead.
sqs-plain.php
Reason of the issue: in the latest Laravel (v5.8), in Illuminate/Queue/Queue.php it is createPayload($job, $queue, $data = '') (ref: https://laravel.com/api/5.8/Illuminate/Queue/Queue.html#method_createPayload)
Illuminate/Queue/Queue.php
createPayload($job, $queue, $data = '')
However, in the /src/Sqs/Queue.php here, it is createPayload($job, $data = '', $queue = null), which is not align to the parent. So that the queue name is passed as $data here.
/src/Sqs/Queue.php
createPayload($job, $data = '', $queue = null)
$data
Issue: Queue names in
sqs-plain.phpis not detected. Always use 'default-handler' instead.Reason of the issue: in the latest Laravel (v5.8), in
Illuminate/Queue/Queue.phpit iscreatePayload($job, $queue, $data = '')(ref: https://laravel.com/api/5.8/Illuminate/Queue/Queue.html#method_createPayload)However, in the
/src/Sqs/Queue.phphere, it iscreatePayload($job, $data = '', $queue = null), which is not align to the parent. So that the queue name is passed as$datahere.