Update LumenServiceProvider.php

[JordanDalton]

Let the developer determine when the job gets deleted. If $event->job->delete() was kept jobs would be deleted regardless if handle() was successful.

[robertwe]

+1 Can we merge it ?

[cristiangrama]

@JordanDalton Not sure this will work. If you remove that part your job will no longer be deleted. In AWS world, the job will stay in the queue and when the visibility timeout expires you're gonna process the job again. Then in all your Jobs that are plain you'll need to manually delete the job.

The standard queue driver uses the CallQueueHandler which will delete the job once it's done (https://github.com/illuminate/queue/blob/master/CallQueuedHandler.php#L57). I guess that the issue here is that the sqs-plain driver does not use a separate handler that would delete the job once done and that's why you need that after event to ensure the deletion. Not the greatest.

Here's a different solution that I have implemented in my own Lumen service provider:

        /** @var QueueManager $queueManager */
        $queueManager = $this->app->make('queue');

        $queueManager->after(function (JobProcessed $event) {
            if ($event->job->getConnectionName() === 'sqs-plain') {
                $event->job->delete();
            }
        });

The above ensures that if you use both the standard and plain queue you'll not get your standard queue job deleted if you instead wanted to release it back to the queue.

To fix it fully I suppose that I could add another check in there to match the queued handler check where I only delete it if it's not already deleted or released back to the queue.

        /** @var QueueManager $queueManager */
        $queueManager = $this->app->make('queue');

        $queueManager->after(function (JobProcessed $event) {
            if ($event->job->getConnectionName() === 'sqs-plain' &&
                ! $event->job->isDeletedOrReleased()
            ) {
                $event->job->delete();
            }
        });

I have not tried yet the second option but that should work I guess.