search

dusterio / lumen-passport

Making Laravel Passport work with Lumen
MIT License
654 stars 139 forks source link

Fix issue after using passport 10 #143

Closed lloricode closed 3 years ago

lloricode commented 3 years ago

Class 'Zend\Diactoros\Response' not found {"exception":"[object] (Error(code: 0): Class 'Zend\Diactoros\Response' not found at /xxx/vendor/dusterio/lumen-passport/src/Http/Controllers/AccessTokenController.php:34)

dusterio commented 3 years ago

@lloricode does it work with older versions as well? I mean, is there going to be any conflict if you, for whatever reason, pick an older version of Passport?

lloricode commented 3 years ago

@lloricode does it work with older versions as well? I mean, is there going to be any conflict if you, for whatever reason, pick an older version of Passport?

i am using laravel v8, and it required passport v10

i think there a big update in passport https://github.com/laravel/passport/compare/v9.3.2...v10.0.1 https://github.com/laravel/passport/blob/v10.0.1/UPGRADE.md

i think you can release it with major version, dropping support for laravel below 7, then minimum passort v10, and with required "zendframework/zend-diactoros": "^2.2"

lloricode commented 3 years ago

because its now good to install zendframework/zend-diactoros in project level while using passport 10 (if working on laravel 8), since this is a vendor level