dusterio / lumen-passport

Making Laravel Passport work with Lumen
MIT License
654 stars 139 forks source link

Error with Lumen 10x #179

Closed emdtem closed 1 year ago

emdtem commented 1 year ago

Problem 1

kumardurairaj commented 1 year ago

Did this package will support for Lumen 10, I am also getting the same error. Please suggest, your response is appreciated.

emdtem commented 1 year ago

Did this package will support for Lumen 10, I am also getting the same error. Please suggest, your response is appreciated.

I think that project it's dead.

Last commit - May 27, 2022

Rasoul-Karimi commented 1 year ago

please update for lumen 10

@dusterio

jmarcher commented 1 year ago

plase update composer file to support lumen 10

@lloricode @sanplomb @benwilkins @MattApril @chris-doehring @santilorenzo @jmarcher @beeards @andrew-s @majidmvulle

What do I have to do with this issue?

jmarcher commented 1 year ago

Do you realize I am not the owner of this repo? This is an open source repo you could either do it yourself or fork it and use a for of it for your own projects.

jmarcher commented 1 year ago

Emmmm no I can not merge anything, I contributed in the past wich does not mean I have rights to merge pull requests... 🤦‍♂️

dusterio commented 1 year ago

Sorry guys didn't get any notifications from GitHub - I just merged the PR, this should be fixed now?

kumardurairaj commented 1 year ago

Thanks a lot @dusterio for your support and contribution in upgrading the package, It helps us a lot, keep up your good work 👍

Rasoul-Karimi commented 1 year ago

i check it not support lumen 10 @kumardurairaj

look to file LumenPassport.php

image

not support lumen 10 !!

@dusterio

Rasoul-Karimi commented 1 year ago

Sorry guys didn't get any notifications from GitHub - I just merged the PR, this should be fixed now?

first please fix your GitHub notification, please!! please

not fixed! look to this file : LumenPassport.php like 67 ! not support lumen 10 i think

dusterio commented 1 year ago

@Rasoul-Karimi can you try again please?

kumardurairaj commented 1 year ago

Hi @Rasoul-Karimi , I upgraded my composer for lumen 10 with below packages : "laravel/lumen-framework": "^10.0", "dusterio/lumen-passport": "^0.3.5",

   it ran without any issues and it got upgraded.
   **Laravel Framework Lumen (10.0.0) (Laravel Components ^10.0)**
image
   Did you still facing issues ? please post here!
Rasoul-Karimi commented 1 year ago

Hi @Rasoul-Karimi , I upgraded my composer for lumen 10 with below packages : "laravel/lumen-framework": "^10.0", "dusterio/lumen-passport": "^0.3.5",

   it ran without any issues and it got upgraded.
   **Laravel Framework Lumen (10.0.0) (Laravel Components ^10.0)**
image
   Did you still facing issues ? please post here!

Omg only install!!! if you can use and test it! we dont tallk aboute install!

image

after install use this command and see that error:

php artisan cache:clear

Rasoul-Karimi commented 1 year ago

@Rasoul-Karimi can you try again please?

I test it, and everything is good! successful :)

kumardurairaj commented 1 year ago

Good to hear @Rasoul-Karimi 👍