search

dustin / go-coap

Implementation of CoAP in go.
MIT License
341 stars 103 forks source link

Add COAPType, COAPCode, OptionID type to all consts #30

Closed dubek closed 9 years ago

dubek commented 9 years ago

Similar to #28.

I don't think adding unit-tests for this makes sense, but if you want me to add them (like you did in 0fab82afe2a86ec1d48738bcd5d21c4c7aa5bc5b for MediaType), I'll add to this pull request.

dustin commented 9 years ago

I agree the test isn't useful. I wrote it for myself since you obviously pointed out something I misunderstood. Thanks for all the help. Sending this up.

On Wed, Sep 23, 2015 at 11:26 AM Dov Murik notifications@github.com wrote:

Similar to #28 https://github.com/dustin/go-coap/pull/28.

I don't think adding unit-tests for this makes sense, but if you want me to add them (like you did in 0fab82a https://github.com/dustin/go-coap/commit/0fab82afe2a86ec1d48738bcd5d21c4c7aa5bc5b

for MediaType), I'll add to this pull request.

You can view, comment on, or merge this pull request online at:

https://github.com/dustin/go-coap/pull/30 Commit Summary

  • Add COAPType, COAPCode, OptionID type to all consts

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/dustin/go-coap/pull/30.