Closed antonsn closed 2 years ago
Huh. That's interesting. We have a thumbnail reference, but they're not serving a thumbnail. I assume you have recent auth?
I can try all thumbnail servers and then fail with a default, but I don't have a solid plan for what to do if they give us media with no thumbnail. I'm curious if the other artifacts are available.
The actionable things I can do here are:
Skipping suggests just ignoring them and not marking them in the DB at all so they'd show up on the next full sync. However, in practice it'd mean there'd be media that exists on their end that you may not be getting.
By marking them, I can have a means of doing extra checks when something doesn't seem right. e.g., has this medium been deleted or something? What kind of broken state are we in?
Thanks for the report. It's not something I've seen, but it's apparently something that can happen that seems inconsistent on the cloud end. I'll hopefully have some time later today to handle this case so we can get the rest of your media to sync and get a useful report to GoPro to fix this service issue.
Apparently I got distracted writing that list this morning. heh.
I think the change I just made should improve things, but I don't have any such broken things.
I didn't bother trying all the image servers, but if we can't get an image, we just store null along with the rest of the metadata and serve that on error.
I did test this by modifying fetchThumbail
to produce an invalid URL one some of my media and got a sync to complete and the "missing thumbnail" thumbnail to show up. You can find the broken media in the DB doing something like:
sqlite3 gopro.db 'select media_id from media where thumbnail is null'
command gopro sync fails with Error below . At the same time gopro upload works fine.