search

dustin / mqtt-hs

Haskell MQTT client.
BSD 3-Clause "New" or "Revised" License
40 stars 25 forks source link

Use uri-bytestring instead of network-uri? #15

Open cdupont opened 3 years ago

cdupont commented 3 years ago

Using uri-bytestring would be much better for constructing URIs. See for example: https://github.com/haskell-servant/servant/issues/139

https://hackage.haskell.org/package/uri-bytestring-0.1.5/docs/URI-ByteString.html

dustin commented 3 years ago

Hey, thanks for the pointer. I hadn't heard of uri-bytestring, but I'll see if it makes my life better or worse. :)

Is there usage of network-uri in here that causes you suffering as a user?

cdupont commented 3 years ago

Yeah, I wanted to construct a URI piece by piece using the constructors, and found it quite strange. For example, the port is defined as a String, that should include ":" (e.g. uriPort = ":42"). Not a big deal, just nit-picking :)