search

dustin10 / VichUploaderBundle

A simple Symfony bundle to ease file uploads with ORM entities and ODM documents.
MIT License
1.85k stars 519 forks source link

Sf6 compatibility #1250

Closed tobias-93 closed 2 years ago

tobias-93 commented 2 years ago

I didn't want to hijack pull request #1237, but I have fixed the tests for Symfony 5.4 and removed the PHP 8.1 deprecations. Symfony 6.0 cannot be tested because knplabs/knp-gaufrette-bundle is not yet SF6 compatible (this was not found in the previous tests, since that didn't properly fix the Symfony version leading to some components still using the 5.4 version). If anyone using SF6 already could test this I would be very grateful.

sxsws commented 2 years ago

still can't install with symfony 6.0.1 and php 8.1?

vich/uploader-bundle dev-master requires symfony/event-dispatcher-contracts ^1.1 || ^2.0 -> found symfony/event-dispatcher-contracts[v1.1.1, ..., v1.1.11, v2.0.0, ..., v2.5.0] but the package is fixed to v3.0.0 (lock file version)

garak commented 2 years ago

For now, you need to use our branch alias

sxsws commented 2 years ago

which branch alias? If I add a custom repository to this repository, when installing dev-master:

vich/uploader-bundle dev-master requires symfony/string ^5.0 -> found symfony/string[v5.0.0, ..., v5.4.0] but it conflicts with your root composer.json require (^6.0).

in composer.json, I see a few problems:

"symfony/event-dispatcher-contracts": "^1.1 || ^2.0", this needs to include "^3.0" "symfony/string": "^5.0"instead of "^4.4 || ^5.0 || ^6.0" "symfony/phpunit-bridge": "^5.4", as above?

If this PR passed, I think the versions on the docker images need to be double-checked