search

dustin10 / VichUploaderBundle

A simple Symfony bundle to ease file uploads with ORM entities and ODM documents.
MIT License
1.85k stars 519 forks source link

Vich\UploaderBundle\Mapping\PropertyMapping marked as @internal #1253

Closed nspyke closed 2 years ago

nspyke commented 2 years ago

Bug Report

Q A
BC Break no
Bundle version 1.19.0
Symfony version 4.4
PHP version 8.0

Summary

The class \Vich\UploaderBundle\Mapping\PropertyMapping has been marked as @internal but it is referenced as an argument in both namer interfaces

PHPStorm is now showing these types with a strike through and a warning.

I feel that anything that has been used in a public interface should not be marked as internal.

Expected behavior

No longer marked as @internal

garak commented 2 years ago

Thanks for reporting. Do you mind opening a PR?

nspyke commented 2 years ago

1254