search

dustin10 / VichUploaderBundle

A simple Symfony bundle to ease file uploads with ORM entities and ODM documents.
MIT License
1.85k stars 519 forks source link

PropertyMapping should not be internal #1260

Closed kappaj closed 2 years ago

kappaj commented 2 years ago

Feature Request

It is no feature, only a small improvement I think ;-)

When you build an custom namer you have to implement the NamerInterface. So you have to create the method name(). One parameter is of type PropertyMapping. But this class is internal. So the IDE shows a warning.

PropertyMapping

Solution:

The class PropertyMapping should not be internal.

garak commented 2 years ago

Thanks for your contribution. Here's a general suggestion: when you find a problem, you should check if the same problem was already solved, e.g. if the same issue was already opened. Looking into currently open issues isn't enough, since it can happen (and it happened in this case) that the issue was already closed (even if the solution is still unavailable in a stable branch).

See #1253