dustin10 / VichUploaderBundle

A simple Symfony bundle to ease file uploads with ORM entities and ODM documents.
MIT License
1.85k stars 520 forks source link

Fix DEPRECATED logs generate by Symfony 6.3 #1399

Closed JoDarma-lp closed 1 year ago

JoDarma-lp commented 1 year ago

Registering \"Vich\\UploaderBundle\\EventListener\\Doctrine\\RemoveListener\" as a Doctrine subscriber is deprecated. Register it as a listener instead, using e.g. the #[AsDoctrineListener] attribute Registering \"Vich\\UploaderBundle\\EventListener\\Doctrine\\UploadListener\" as a Doctrine subscriber is deprecated. Register it as a listener instead, using e.g. the #[AsDoctrineListener] attribute Registering \"Vich\\UploaderBundle\\EventListener\\Doctrine\\CleanListener\" as a Doctrine subscriber is deprecated. Register it as a listener instead, using e.g. the #[AsDoctrineListener] attribute. Registering \"Vich\\UploaderBundle\\EventListener\\Doctrine\\RemoveListener\" as a Doctrine subscriber is deprecated. Register it as a listener instead, using e.g. the #[AsDoctrineListener] attribute Registering \"Vich\\UploaderBundle\\EventListener\\Doctrine\\UploadListener\" as a Doctrine subscriber is deprecated. Register it as a listener instead, using e.g. the #[AsDoctrineListener] attribute

You should to update the code to use new attribute #[AsDoctrineListener] to avoir Symfony deprecated message when using your Bundle.

garak commented 1 year ago

Duplicate of #1388

JoDarma-lp commented 1 year ago

Yep, but deprecated message are always logs #1391 doesn't totally fix the deprecated message

mdriessen commented 1 year ago

@garak Do you have any timeline for tagging a new release with these fixes?

garak commented 1 year ago

@garak Do you have any timeline for tagging a new release with these fixes?

it looks like the deprecations is not solved...

mdriessen commented 1 year ago

@garak Do you have any timeline for tagging a new release with these fixes?

it looks like the deprecations is not solved...

I'm on Symfony 6.3 and getting the deprecations on VichUploader v2.1.1. When switching to dev-master (05f4df4) the deprecations are solved. Using the attribute #[AsDoctrineListener] is not required, it's just a possible way of registering the listener instead of configuring it in XML.

So I'm not sure what @JoDarma-lp is referring to... did you try the dev-master version?

JoDarma-lp commented 1 year ago

I'm working on Symfony 6.3 and "vich/uploader-bundle": "2.1.1" and the deprecations still here.

How you turn on dev-master version ?

mdriessen commented 1 year ago

Use "vich/uploader-bundle": "^2.1@dev" and run composer update vich/uploader-bundle.

The deprecation Method getEntityManager() is deprecated and will be removed in Doctrine ORM 3.0. Use getObjectManager() instead. still exists. But that's only when removing a file. The above deprecation triggers 4 times per request.

endelwar commented 1 year ago

I can confirm no more User Deprecated: Since symfony/doctrine-bridge 6.3: Registering "Vich\UploaderBundle\EventListener\Doctrine\UploadListener" as a Doctrine subscriber is deprecated. Register it as a listener instead, using e.g. the #[AsDoctrineListener] attribute.

on Symfony 6.3.2 with

"vich/uploader-bundle": "dev-master"

laurentmuller commented 1 year ago

I have tested with Symfony 6.3.3 and the only remaining deprecation is:

User Deprecated: Method Doctrine\ORM\Event\LifecycleEventArgs::getEntityManager() is deprecated and will be removed in Doctrine ORM 3.0. Use getObjectManager() instead.

It is explained in #1393 and resolved in #1395.

laurentmuller commented 1 year ago

We can use the #[AsDoctrineListener] attribute but then all listeners are registred even if the user does not require one. See the registerListeners method on the VichUploaderExtension class.

mdriessen commented 1 year ago

Any reason #1395 was closed without being merged?

garak commented 1 year ago

Any reason #1395 was closed without being merged?

It was closed by PR author himself

laurentmuller commented 1 year ago

This was a mistake from me. I have re-opened.

Sorry...