download_uri should use publicUrl when using FlysytemStorage

dustin10 / VichUploaderBundle

A simple Symfony bundle to ease file uploads with ORM entities and ODM documents.

MIT License

1.83k stars 519 forks source link

download_uri should use publicUrl when using FlysytemStorage #1418

Closed erichard closed 4 months ago

erichard commented 9 months ago

Feature Request

Q	A
New Feature	yes
RFC	yes
BC Break	no

Summary

When using the flysystem storage adapter, we could use the publicUrlGenerator defined on the storage. This way we can get direct url to S3 files or others storage provider.

Possible implementation

From my tests, I think we only need to implement resolveUri() method in the Vich\UploaderBundle\Storage\FlysystemStorage

sovetski commented 5 months ago

Any update on it please?