search

dustin10 / VichUploaderBundle

A simple Symfony bundle to ease file uploads with ORM entities and ODM documents.
MIT License
1.83k stars 519 forks source link

Revert changes of #1441 #1444

Closed sovetski closed 4 months ago

sovetski commented 4 months ago

It looks like it is a breaking change, as mentionned by 3 people here: https://github.com/dustin10/VichUploaderBundle/pull/1441

Maybe in the future it will be implemented in a major release (I hope)

sovetski commented 4 months ago

@garak it's a good idea. I can add this information to the documentation for people who will want this feature. With custom storage, it will be simple to implement. Let me try to explain it.

Edit: Done, let me know if it is not ok or not clear

sovetski commented 4 months ago

@garak was it related to the last link that I added? If yes, I fixed it, and used a markdown validator to be sure that it is valid.

garak commented 4 months ago

@garak was it related to the last link that I added? If yes, I fixed it, and used a markdown validator to be sure that it is valid.

As you can see in the related Action, we enforce a custom rule about the maximum length of the lines.

wizhippo commented 4 months ago

FlysystemStorage is final, you cannot extend it.

sovetski commented 4 months ago

FlysystemStorage is final, you cannot extend it.

Yes, maybe my wording is not correct, but I was meaning that we have to duplicate its code

garak commented 4 months ago

@sovetski still waiting for a fix in the markdown

sovetski commented 4 months ago

@garak sorry for the delay, it looks OK now