search

dustinblackman / Championify

Import recent item sets from popular aggregators like Champion.gg in to League of Legends to use within game! No hassle.
MIT License
891 stars 157 forks source link

Special Items/Upgrades #167

Open Nefari0uss opened 8 years ago

Nefari0uss commented 8 years ago

Some champions have special things they buy in the shop. For Gangplank, he has his ult upgrades. Not sure champion.gg tracks which upgrade is taken first/second/third but at any rate, an option to upgrade when running the top/mid page would be very nice. (This alleviates having to goto recommended or all items). Not sure about Rengar or Khazix since I don't own either of those champions. Kalista is fine since she starts with the item IIRC.

dustinblackman commented 8 years ago

Unfortunately the source would have to track that data in order for me to import it. For Gangplank champion.gg doesn't from what I can see quickly glancing. Then again there are champs that do track special items like Viktors.

If there are other sources that support Gangplanks items then they'll automatically be included in Championify, otherwise I'm not currently aggregating data myself.

Nefari0uss commented 8 years ago

I'm not quite sure I understand ~ why is there a need to aggregate data? Some champions have items/upgrades that only they can use. Is it not possible to add special conditions for those champions and display them at the top/bottom of the list in alphabetical order (perhaps after consumables)?

dustinblackman commented 8 years ago

Ah, that could be done yes!

ilanbiala commented 8 years ago

@dustinblackman has this been done? Champions like Gangplank make heavy use of these upgrades and it would be nice to have them on the same page.

dustinblackman commented 8 years ago

Last I had checked, Champion gg started including this in their responses, but it's been a bit since I've looked at it.

ilanbiala commented 8 years ago

@dustinblackman it's at the end of this file https://github.com/joel1st/championweb/blob/master/api_data/items.json, is that where you're pulling from?

dustinblackman commented 8 years ago

@ilanbiala Currently I'm still scraping Champion.gg due to their API being unreliable, and then joel setting up Cloudflare correctly to make response times quick. Now that I'm on a computer I'm seeing the items are still not on the actual Champion.gg page. It'll probably have to be a manual solution to add it to champions, which is what I had suggested in my previous comments.