search

dustinblackman / Championify

Import recent item sets from popular aggregators like Champion.gg in to League of Legends to use within game! No hassle.
MIT License
891 stars 157 forks source link

Adding Lolalytics as a source #221

Closed WereGoingOcean closed 7 years ago

WereGoingOcean commented 7 years ago

Added lolalytics as a build source. Added a few new translation keys to match up with the headers from the lolalytics site.

Fixes https://github.com/dustinblackman/Championify/issues/212

dustinblackman commented 7 years ago

@WereGoingOcean Wow this is massive, thanks! Don't worry about the unmatched translation keys test. I'm realizing that isn't a great test to be run against PRs, and will need to think of a better way to handle it. I'll go over the PR tonight. :)

WereGoingOcean commented 7 years ago

Sounds good!.

WereGoingOcean commented 7 years ago

Alright, all the changes you asked for should be in there now.

dustinblackman commented 7 years ago

Looks great! Thanks again.