dustinblackman / Championify

Import recent item sets from popular aggregators like Champion.gg in to League of Legends to use within game! No hassle.
MIT License
890 stars 157 forks source link

Support to set item slots across all the item sets? #331

Closed xoxfaby closed 6 years ago

xoxfaby commented 7 years ago

New patch added item slots preference to items, would be great to be able to apply this to all item sets added by championify.

http://na.leagueoflegends.com/en/news/game-updates/patch/patch-717-notes

SalGnt commented 7 years ago

+1

dustinblackman commented 7 years ago

Ah this is nice! However that may only be for item sets created in the client rather then imported as I'm not seeing anything new in the docs. I'll check either way. Thanks!

xoxfaby commented 7 years ago
"preferredItemSlots":  
    [
        {
            "id":"2031",
            "preferredItemSlot":1
        },
        {
            "id":"3142",
            "preferredItemSlot":2
        },
        {
            "id":"3814",
            "preferredItemSlot":0
        }
    ]

honestly, looking at how simple that is, I'm surprised you haven't implemented it yet. If nothing else give a way to append some text to every file so I can put my preferred item slots in there.

dustinblackman commented 7 years ago

@xoxfaby I haven't tested preferredItemSlots, nor is it in the docs. I'm guessing it was found in item sets created by the lol launcher?

xoxfaby commented 7 years ago

Yup, took about 5 minutes to find by making one in the launcher and seeing it.

dustinblackman commented 7 years ago

While I like the idea of it, I won't have the time anytime soon to add a UI in order for users to customize item slots. PRs are welcome.

xoxfaby commented 7 years ago

I would try but I haven't worked in Java in a long time and I have no idea what to even work in for this.

WereGoingOcean commented 7 years ago

@xoxfaby if you manually add the preferredItemSlots section to a Championify item set does it work for you in game? When I tried it the Championify generated set wouldn't put the items in their preferred slot, only the client created ones worked.

volt255 commented 6 years ago

@WereGoingOcean: you are correct. I tried manually adding the section preferredItemSlots with a simple "replace in files" from notepad++ . I simply replace all files with filename: CIFY*.json and I replaced the text:

"mode": "any",

with:

"mode": "any", "preferredItemSlots": [ ... ], from an item set with all of my preferred Item Slots. BUT, when i go to the practice tool, only the item sets created by the client work, Apparently its a game issue when working with third party item sets it does not load the "preferredItemSlots" section.

dustinblackman commented 6 years ago

This is not possible with how League is written, we can't add preferred item slots. Will reopen the issue if access becomes available.