search

dustinblackman / Championify

Import recent item sets from popular aggregators like Champion.gg in to League of Legends to use within game! No hassle.
MIT License
889 stars 157 forks source link

Setup "failed", but still works. #366

Closed brianj64 closed 6 years ago

brianj64 commented 6 years ago

Something's wrong with the current installer, faulty stating that setup failed due to some exception, yet the program still works fine without any problems.

This is on a fresh Windows 10 Pro x64 version 1709(FCU)

Never had this issue on version 1703(CU)

Setup log: https://pastebin.com/ZSXL35LQ

hollowsxd commented 6 years ago

did you run it with admin access?

brianj64 commented 6 years ago

Yes i did, both get the same error.

dustinblackman commented 6 years ago

Odd, it looks like something broke with the squirrels installer. Championify is currently a few versions behind, I can look in to updating it if it won't cause any issues.

brianj64 commented 6 years ago

Seems like Discord also uses Squirrel so i made a fresh log: https://pastebin.com/vXsap17y This is after wiping the SquirrelInstaller log and completely uninstalling Championify and made sure to delete all leftover files.

2017-11-22 08:56:18> ApplyReleasesImpl: Couldn't rewrite shim RegKey, most likely no apps are shimmed: System.NullReferenceException: Object reference not set to an instance of an object.

This is what must be causing the setup failed dialog. From my programming experience, null reference exceptions are never a good thing(since you should always instantiate an object reference before it's being used).