search

dustinblackman / Championify

Import recent item sets from popular aggregators like Champion.gg in to League of Legends to use within game! No hassle.
MIT License
889 stars 157 forks source link

Update garena checks for the new patch #367

Closed hollowsxd closed 6 years ago

hollowsxd commented 6 years ago

Fix #291

dustinblackman commented 6 years ago

Ah, so this is the new path in garena? Brilliant, thanks! I'm unsure why the Travis builds failed, I've triggered a rerun. However it looks like you'll need to update the path manager tests with the new exe before it can be merged.

hollowsxd commented 6 years ago

@dustinblackman weird bcs I just forked it and pushes the changes and it seems to be working, maybe I overlook some things lol, I will take a look again and hopefully fix it :+1:

dustinblackman commented 6 years ago

I'd assume it's working, but it's just the tests need to be updated along with it. :) https://github.com/dustinblackman/Championify/blob/master/tests/path_manager.js#L83-L94

hollowsxd commented 6 years ago

@dustinblackman ah I see now, my bad

hollowsxd commented 6 years ago

I changed it again so that the root folder get selected instead of the Game folder, also updated the test