search

dustinblackman / Championify

Import recent item sets from popular aggregators like Champion.gg in to League of Legends to use within game! No hassle.
MIT License
890 stars 157 forks source link

Suggesting 2 new features #422

Open DarkRobotix opened 5 years ago

DarkRobotix commented 5 years ago

1) Replace regular items with their Quickcharge counterpart

Description of feature: Option to or automatically replace items such as Rod of Ages and Tear of the Goddess items (Tear of the Goddess, Archangel's Staff/Seraph's Embrace and Manamune/Muramana) to their Quickcharge couterparts on non-SR maps in item sets, instead of leaving it out completely like now

Mocks/screenshots of ideas:

2) Display role playrate

Description of feature: Show role playrate of that champion as a percentage next to item set name eg: 17.4% of the time Galio is picked as Top and 63.7% as Mid as of Patch 8.11 (fake data)

Mocks/screenshots of ideas: https://imgur.com/IlKUqSF

hollowsxd commented 5 years ago

For feature 1, I think both have the same item id? correct me if i'm wrong (I am wrong) and for feature 2, placing the percentage next to item set same would clutter it IMO but it can be done

EDIT: It appears that both item have different id, eg: rod of ages-3027 while quick charge roa-3029

DarkRobotix commented 5 years ago

Yep, the item completely disappears from the build because they have different IDs. There are more items that fall into this category too like Wooglets on Twisted Treeline, which is DCap+Zhonyas, so if the build had one of those it could also be swapped to Wooglets instead.

But the reverse of this idea could be useful too. For example, having the Special Poro Snax from Poro King in every build. But since they only show up in the shop in that specific mode, They won't clump up the shop for games in other modes. I don't know about Ornn upgrades as they sometimes show up in custom item sets and others not (and sometimes 2 times) but could be permanently 'forced' in there as well. Same goes for GP and Viktor Upgrades and some other champion/game mode specific items like buildings in Nexus Siege etc

This is solely for the convenience of not having to switch back and forth to the regular shop and your item set to purchase these items. Not sure how much more space/resources this would take so it could be a tick box so people who don't want this or their potato machines can't handle it can opt out for this function.

maybe feature 2 could be a tick box too so only people who want the stat will see it