search

dustinblackman / Championify

Import recent item sets from popular aggregators like Champion.gg in to League of Legends to use within game! No hassle.
MIT License
890 stars 157 forks source link

Pull ARAM item sets from LOLAlytics with LOLFlavor going down #444

Open jeffpignataro opened 5 years ago

jeffpignataro commented 5 years ago

Pull ARAM item sets from LOLAlytics with LOLFlavor going down. Updated translations for LOLAlytics. Also updated a number of packages.

sargonas commented 5 years ago

Amusing, I was literally going to make this same change tonight, and thought to glance here and lo and behold, LOL

jeffpignataro commented 5 years ago

Unfortunately, I'm not sure @dustinblackman is still maintaining the app which means it may never make it in. But at least I have it working locally now.

LordBoos commented 5 years ago

This actually works, but the imported format from LOLAlytics is really bad compared to good old LOLFlavor. For few champions I've tried there are like all the existing starting items (like 10+ items lol) recommended in the build and all those "most frequent first, second etc. item" just list 5+ different possible items. Don't get this bad, I like that you made this change and we now have at least something, but LOLAlytics format is really bad.

jeffpignataro commented 5 years ago

I totally agree. I didn't really like the layout either. I could definitely do some cleanup on it - perhaps reducing the number of items returned might go a long way to improving it. That said, I'd just love to get anything at this point.

sargonas commented 5 years ago

If you're willing to do some cleanup work on it for the greater good, I'll go chat with @dustinblackman. Given my background, and the fact he knows me, I'm hoping I can get him to give me access to collaborate on merging in pull requests and take over maintaining it without having to take the extra step of forking Championify to a new version of my own. (I would much rather leave it living here, since he put so much blood sweat and tears into the project).

My vision, since he no longer has the time and resources to maintain it, is to take over maintaining the general releases of it and let the community start contributing more (with adequate review and oversight, naturally!).

jeffpignataro commented 5 years ago

That sounds great @sargonas! I'll carve out some time this week (maybe over next weekend) and see if I can't improve the presentation and usability somewhat and circle back.

oMattz commented 5 years ago

How do I get this pull request on my application?

jeffpignataro commented 5 years ago

How do I get this pull request on my application?

Sorry, I've had almost no time the last couple weeks and I've been meaning to get this cleaned up and finished so that it can be integrated into the master branch. If you want something quicker (and have the capability of building it locally) you could fork my repo, build it, and run it locally on your machine.

jeffpignataro commented 5 years ago

@sargonas, Sorry for the delay on getting back to this. I went ahead and cleaned up the look and feel for the LoLAlytics ARAM item sets. I also applied map filters on all LoLAlytics item sets so that the ARAM ones are only on Howling Abyss and the others apply to Summoner's Rift. As part of adding the map filter, I did have to adjust the test fixtures as they were previously set to "map" : "any".

Unless you have any other suggestions or adjustments, I think everything is ready to go. If you're able to touch base with @dustinblackman in hopes of getting the app updated I'm sure many would really appreciate it. Thanks a lot!

sargonas commented 5 years ago

I spoke to him briefly back when I checked in, he's keen on the idea of opening up support to others like me to help approve and merge in community updates to keep it alive and fresh, since he no longer has the time to support it, though he says there is some work he wants to do on his side first to make it ready for that, since right now it's not. He didn't explain what exactly, but I suspect it's related to the myriad of dependency and deprecation errors I got myself when I tried to set up the repo from scratch and build my own up to date version.

In any event, I did not follow up with him a second time when I should have, so I'll go bug him again shortly. I'm committed one way or another to helping out, just be patient with me while I try. :D

jeffpignataro commented 5 years ago

Understandable. It was quite a struggle getting things working when I pulled the code down the first time (especially on Windows where you can't even run tests). Let him know if he needs any help I, and I'm sure others, would be happy to help clean things up if he just wants to give some direction. Thanks for the help.