search

dustinblackman / Championify

Import recent item sets from popular aggregators like Champion.gg in to League of Legends to use within game! No hassle.
MIT License
889 stars 157 forks source link

Auto Update item sets #56

Open dustinblackman opened 9 years ago

dustinblackman commented 9 years ago

Overview

Have Championify run in the background with a tray icon, as well as a view to notify of when the last update happened. The import button would more or less need to be converted to save button to prevent users from running an import just to save preferences.

nilesr commented 9 years ago

Would this be something that runs at login in the background, or something on a fixed schedule? Maybe have a process that detects when you launch League and updates then, though that sounds hard to properly implement.

dustinblackman commented 9 years ago

Technically, both. Auto update on run, and then continue to update on a fixed schedule. It'll be up to the user to decide whether they want it to run on boot or not. Electron I believe has a tray feature for Windows/OSX, I'd start somewhere there when I get around to it. :)

josevill commented 9 years ago

https://github.com/atom/electron/blob/master/docs/api/tray.md API Doc about the tray feature thing.

ilanbiala commented 8 years ago

@dustinblackman any update on this? This would be a really nice feature, even to have run once a week.

dustinblackman commented 8 years ago

It's pushed near the bottom of the backlog at the moment. My development time has been rather limited lately. Contributors are welcome.

colbin8r commented 7 years ago

@dustinblackman I'm a developer familiar with Electron (but not worked with it yet)--interested in a hand? I'm not sure that Electron permits background services natively so this may portion have to be written in something else. Thanks for a great app! 👍

dustinblackman commented 7 years ago

Sure I'd love some help! Electron can for sure do background process', you can control when the window is shown and when it's not. The idea would be to have it running without a visible window, but in the tray instead, and a scheduled task to pull in sources.

iggyvolz commented 7 years ago

Could you also use Task Scheduler (or something of the sort) to run championify.exe --autorun on a schedule?

josevill commented 7 years ago

@iggyvolz It could be setup as a .BAT file that runs a command to schedule such task in case you're running Windows, I don't know how it'd be using OSX.

Windows Task scheduler: schtasks /create /sc DAILY /tn "Update Championify Lists" /tr "dir-to-championify-binaries" /st 10:00

dustinblackman commented 7 years ago

The idea is to have it built in rather then a separate scheduler.

colbin8r commented 7 years ago

@dustinblackman Could you link to the Electron docs that allow headless running of the app? The only ideas I could find were this: https://discuss.atom.io/t/headless-electron/20173/3

colbin8r commented 7 years ago

Also: https://discuss.atom.io/t/windows-background-service/20777/6

Nefari0uss commented 7 years ago

Please make sure that this is opt-in. I'm not a fan of applications that decide to run on startup without my permission.

colbin8r commented 7 years ago

@dustinblackman I've forked your repo and started working on it. I'm certainly not as familiar with Electron as I thought, though! 😛

cafeina-software commented 7 years ago

This feature also should be able to detect if LoL is opened or not, and only update item sets if LoL is not running. I don't know what happens if Championify tries to update itemsets while running the clients or the game.

dustinblackman commented 7 years ago

@fuckyourselfup Nothing. The updates item sets just won't be seen in game until the next match.

computergeek125 commented 6 years ago

At minimum, I'd use the batch job feature. I'd set it up with the Windows task scheduler or cron/launchd on macOS. I'm not great at the code section, but I'm willing to beta test it