dustindclark / homebridge-rinnai-controlr

Rinnai Control-R interface for homebridge
Apache License 2.0
12 stars 8 forks source link

Error on values reporting during plugin load #25

Open AlSmyth81 opened 5 months ago

AlSmyth81 commented 5 months ago

Describe The Bug: Receive an error message when plugin loads.

To Reproduce: resetart the HB plugin

Expected behavior: No reported errors

Logs:

[28/04/2024, 15:49:51] [homebridge-rinnai-controlr] This plugin generated a warning from the characteristic 'Target Temperature': characteristic was supplied illegal value: number 45.888888888888886 exceeded minimum of 48.888888888888886. See https://homebridge.io/w/JtMGR for more info.

Plugin Config:

{ "username": "thisismy@email.com", "password": "thisismypassword", "recirculationDuration": 15, "temperatureUnits": "F", "minimumTemperature": 120, "maximumTemperature": 140, "platform": "RinnaiControlR" }

Screenshots:

Screenshots:

Environment:

Plugin Version: v1.0.26

Homebridge Version: v1.8.1

Node.js Version: v20.12.2

NPM Version: unknown

Operating System: Raspbian

wtrunnell commented 3 months ago

I got this return when my homebridge "UI Settings" we set to Celsius and my Rinnai was configured to Fahrenheit.

My guess this not a bug.

AlSmyth81 commented 3 months ago

I got this return when my homebridge "UI Settings" we set to Celsius and my Rinnai was configured to Fahrenheit.

My guess this not a bug.

With your comment on F/C mismatch, I went into the ControlR app to check. The unit is displaying in F. The HB is displaying in F I do wonder if the conversion value is being mishandled somewhere... The value reported is 114.6 F; and my unit is set for 115. The Min allowed value reported is 120.0 F

It seems the Plugin places a required minimum that is not in line with the ControlR App values. I did attempt to scroll down as far as possible on the app - it went to 98 F and then gave a message 98 is an invalid setting (the unit had started running before I attempted) I was then able to move it up to 120, which is higher than needed, After a restart of HB, no error in the logs. I then set ot down to 110 and restarted HB again - still no error. This all seems very odd that this error repeated several times at the moring hour, then seems to have cleared. I am wondering where this value is really coming from, how is is comparred to this 114.8-120 valuation.

Also, seems the original report did not ask for the ControlR app and system values App version 2.5.7 Firmware 238 (Also says "Latest Build" No options to upgrade either one are available in the app.