dustindclark / homebridge-rinnai-controlr

Rinnai Control-R interface for homebridge
Apache License 2.0
12 stars 8 forks source link

Recirculation feature no longer working? #9

Closed guillochon closed 2 years ago

guillochon commented 2 years ago

Describe The Bug: Can no longer turn recirculation on with the plug-in. The state of recirculation still appears to be read correctly (if I turn it on externally via the control-r app), but I can no longer turn on recirc via this plugin. This is a recent development, within the past 48 hours.

To Reproduce: Try to turn on recirculation via the homebridge switch, nothing happens.

Expected behavior: Recirculation should turn on.

Logs: No logs produced.

Environment:

Bleh55 commented 2 years ago

I just noticed this same thing last night..

tedinorbit commented 2 years ago

I’m noticing this as well. I also cannot change temperature. Not sure if it’s related

tedinorbit commented 2 years ago

I just noticed a firmware update on my control-r unit was available. Perhaps there were some breaking api changes?

Bleh55 commented 2 years ago

No mention of what the fix is, but the Home Assistant forum seems to have identified same/similar issue, and may have a fix (last few comments).

https://community.home-assistant.io/t/rinnai-tankless-water-heater-control-r-module-integration/100646/38

Edit: looks like the version log pinpoints the issue:

“fix for Rinnai blocking unauthenticated URL by @explosivo22”

https://github.com/explosivo22/rinnaicontrolr/releases

explosivo22 commented 2 years ago

Yeah Rinnai made a part of the API that was being utilized forbidden and changed it over to an authenticated request only.

guillochon commented 2 years ago

@dustindclark do you think you'd be able to apply the fix above to the homebridge plugin?

dustindclark commented 2 years ago

Fixed in 1.0.15.

guillochon commented 2 years ago

I can verify that this fix works for me! Thanks so much @dustindclark!