search

dustinfarris / ember-django-adapter

Ember CLI addon adapter for Django REST Framework
http://dustinfarris.github.io/ember-django-adapter
MIT License
191 stars 49 forks source link

Update ember and ember-data to 2.17. Fix deprecations. #207

Closed m-basov closed 6 years ago

m-basov commented 6 years ago

Hi @dustinfarris! I did upgrade to addon with ember-cli-update. Fixed deprecations. Could you test and merge it if all works well?

Closes #205 and #206

UPD. Tests are passing locally but I am trying to fix them at CI.

UPD. @dustinfarris could you check CI settings please? Seems some very old image is used. Ping me so we can resolve issue together.

dustinfarris commented 6 years ago

@kolybasov thank you so much for this!

You're right, CircleCI was running on a Ubuntu 12.04 image that doesn't come with yarn. I updated the setting to 14.04 (with yarn) and made a slight modification to circle.yml based on their docs.

m-basov commented 6 years ago

@dustinfarris thanks for the fix! Let me know if I need to made some changes to merge this.

dustinfarris commented 6 years ago

@kolybasov all good! really can't thank you enough for putting time into getting this done. 💙💙💙

will do a major version release since the supported versions of Ember have changed