search

dustinfarris / ember-django-adapter

Ember CLI addon adapter for Django REST Framework
http://dustinfarris.github.io/ember-django-adapter
MIT License
191 stars 49 forks source link

Update to 3.0. Fix tests by updating to ember-qunit RFC 232 & 268 style. #215

Closed benmurden closed 5 years ago

benmurden commented 5 years ago

In this update

Resolves #212 and #210.

benmurden commented 5 years ago

Tests are noisy because of deprecations used in older ember-data versions. Could be remedied by including concomitant ember-source versions in ember-try.js.

dustinfarris commented 5 years ago

@oleroel would you mind reviewing this?

OleRoel commented 5 years ago

@dustinfarris @benmurden

After going through the 25 files changed for a first time I couldn't find a thing that doesn't look correct to me. Although I've to admit that I don't know if some changes have been made by the ember-cli-upgrade --run-codemods command (e.g. in .eslintrc.js or testem.js). And I just cloned the update-to-3.0 branch but didn't ran the tests nor did I try to use the repository in my own projects. I can offer to do this tomorrow (it's getting late here). But (again) I cannot guarantee to finish it, there are some other task on my plate for tomorrow.

dustinfarris commented 5 years ago

Thanks @OleRoel. Please merge this when you are able to confirm that it works in your own project.

OleRoel commented 5 years ago

@dustinfarris @benmurden Status update: my other task took some time, I am going to review the code tomorrow. And please excuse the delay.

OleRoel commented 5 years ago

@dustinfarris @benmurden I just merged Ben's branch into master. Shouldn't we bump the tag? v2.0.0.is the latest. If yes, the version in the package.json should be updated.

Furthermore: My "Update ember-data to version 3.0" pull request can be closed. And the "Update to Ember-Data v3.0" issue can also be closed.

Who is taking the action?

And, my log now shows:

DEBUG: -------------------------------
DEBUG: Ember                : 3.3.1
DEBUG: Ember Data           : 3.3.1
DEBUG: Ember Bootstrap      : 2.0.0
DEBUG: Ember Django Adapter : 2.0.0
DEBUG: Ember Simple Auth    : 1.7.0
DEBUG: -------------------------------
OleRoel commented 5 years ago

@benmurden @dustinfarris

Great, CircleCI fails with here with

Command python setup.py egg_info failed with error code 1 in /tmp/pip_build_root/tornado
Storing debug log for failure in /home/ubuntu/.pip/pip.log

sudo pip install mkdocs returned exit code 1

Action failed: sudo pip install mkdocs

And before:

ImportError: Tornado requires an up-to-date SSL module. This means Python 2.7.9+ or 3.4+ (although some distributions have backported the necessary changes to older versions).

This looks to me like an issue that is not caused by the merged code.

And there is another warning in the head section:

This project is currently running on CircleCI 1.0 which is no longer supported. Please start migrating this project to CircleCI 2.0.

Uhm, I will do some research what might have caused the issue.

Update 1 The culprit is found in the circle.yml: https://github.com/dustinfarris/ember-django-adapter/blob/master/circle.yml#L17

Update 2 I've created a new issue 216

Update 3 The CI tasks 438 had tornado 4.5.2 as sub-dependency. tornado>=5.0 requires a different Python than that one installed in the CircleCI ~container~ machine.

Update 4 I am currently looking into updating to CircleCI 2.0 and use Docker circleci/node:8.0 container in the config on my fork of ember-django-adapter.

Update 5 This is a first draft of a circleci 2.0 version for the CI task: https://github.com/OleRoel/ember-django-adapter/blob/circleci-20-test/.circleci/config.yml Issues:

dustinfarris commented 5 years ago

Thanks for the hard work on this. Will bump the version when CircleCI is happy (see #217).

dustinfarris commented 5 years ago

v2.1.0 released