Update to CircleCI 2.0 - Githubissues

dustinfarris / ember-django-adapter

Ember CLI addon adapter for Django REST Framework

MIT License

191 stars 49 forks source link

Closed benmurden closed 5 years ago

benmurden commented 5 years ago

Deploy step will only run when a commit is tagged with /v.*/.
Deploy is the only step which will have access to write to the repo.
The deploy job requires that there be a new read/write ssh key added to the GitHub repo and CircleCI.
@dustinfarris will need to generate and add the key pair, then update the config fingerprint with the one shown on CircleCI.

Resolves #216.

OleRoel commented 5 years ago

The PR is looking good to me.

@dustinfarris Should I just run the merge or do you want to do it? Here are the steps described for creating the ssh key for CircleCI together with the fingerprint that needs to be filled out in the config.yml: https://circleci.com/docs/2.0/gh-bb-integration/#creating-a-github-user-key