dustinfarris / ember-redux-route-connect

Connect your routes to redux state/dispatch
MIT License
5 stars 2 forks source link

[bug] remove ember-redux from runtime deps #13

Closed foxnewsnetwork closed 7 years ago

foxnewsnetwork commented 7 years ago

Background

Since ember-redux 2.0.0, ember-browserify requirement has been dropped. However, because package.json has a ember-redux: '1.9.1' runtime dependency, npm will install ember-redux: '1.9.1' into the node_modules of ember-redu-route-connect addon when it is installed by an end-user. So if the end-user is running ember-redux:2.x.x'and doesn't haveember-browserifyinstalled,ember build` will croak.

Changes

Suggestions

If we truly wanted to force an version of ember-redux on an user, we would need to write a blueprint.

ember g blueprint ember-redux-route-connect

then use the addAddonsToProject method in the afterInstall hook:

addAddonsToProject({
  packages: [
    { name: 'ember-redux', target: '2.1.0' }
  ]
});
dustinfarris commented 7 years ago

Might be worth adding it back in as a peer dependency if compatibility was ever an issue. But it's not for now. Thanks for the PR.