Implement immutable value in dev mode.

dustingetz / react-cursor

Immutable state for React.js

1.03k stars 50 forks source link

Implement immutable value in dev mode. #69

Closed lijunle closed 8 years ago

lijunle commented 8 years ago

Resolve #54
Detect dev mode according to NODE_ENV environment variable.
Deep freeze value object with the example from MDN.
Re-user some of @danielmiladinov 's code

Note:

Please be attention with the behavior of Object.freeze. According to MDN's description:

If no use strict, nothing happens when touch the value property
If use strict, TypeError is thrown.

dustingetz commented 8 years ago

cc @danielmiladinov

dustingetz commented 8 years ago

Looks good, I intend to merge unless Danny objects

lijunle commented 8 years ago

:sob: My test is failing, because Travis is using Chrome 37 to run my test. It seems behavior like ES5 - MDN said Object.getOwnPropertyNames will throws TypeError when argument is not object.

However, I will fix the test failure.

dustingetz commented 8 years ago

Do you need me to bump version and publish?

react-cursor 2.0 will be coming soon, this will be part of 2.0 as well.

lijunle commented 8 years ago

I am OK with both options. That is your decision. :)