dustinkirkland / hollywood

2.8k stars 254 forks source link

Use find instead of locate #61

Closed faxm0dem closed 1 year ago

faxm0dem commented 2 years ago

On some systems, the locate database is empty, or disabled, resulting in empty output of code and jp2a:

locate: can not stat () `/var/lib/mlocate/mlocate.db': No such file or directory

This change uses find instead, which works always. Drawback : there is no limit of items. We could add -maxdepth but it wouldn't have the same effect

dustinkirkland commented 1 year ago

Thanks! I've added this, with some modifications. Appreciate it.

faxm0dem commented 1 year ago

Thanks ! I see you close all issues instead of merging. This is maybe because you're not working directly with git ?

dustinkirkland commented 1 year ago

That's kind of right... I've historically used Launchpad.net and bzr (both associated with Ubuntu), as the the "upstream", and treated Github and git as a mirror. So I take the patches, apply them, push them to Launchpad first, and then Github afterward, keeping them in sync. That said, I'm planning to move from Launchpad to Github at some point.

faxm0dem commented 1 year ago

I understand. May I suggest a little CONTRIBUTORS.md file then in the meantime :-)

dustinkirkland commented 1 year ago

Sure, I think what you're looking for is here: https://github.com/dustinkirkland/hollywood/blob/master/debian/changelog

@DustinKirkland

On Mon, Jul 3, 2023 at 2:58 AM Fabien Wernli @.***> wrote:

I understand. May I suggest a little CONTRIBUTORS.md file then in the meantime :-)

— Reply to this email directly, view it on GitHub https://github.com/dustinkirkland/hollywood/pull/61#issuecomment-1617571074, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMZBWYTEAOB7ZXKFAMOITXOJ3TNANCNFSM6AAAAAAQMF3G2I . You are receiving this because you modified the open/close state.Message ID: @.***>