dustinlacewell / vcv-minilab3

6 stars 0 forks source link

There are some minor formatting errors. #4

Closed squinkylabs closed 1 year ago

squinkylabs commented 1 year ago

I noticed that in the widget constructor you seem to not use your normal conventions for brace indenting?

    std::vector<Vec> knobPositions = {
        Vec(6.445, 84.75),
        Vec(22.119, 84.75),
        Vec(38.768, 84.75),
        Vec(56.03, 84.75),
        Vec(6.445, 97.364),
        Vec(22.119, 97.364),
        Vec(38.768, 97.364),
        Vec(55.428, 97.364)};

Shouldn’t that last brace be on a new line, in the same column as “std”? for that matter, doesn’t your code editing environment format code for you?

Another minor odd formatting thing is in BaseParam.hpp. It’s the only place you use public/protected, and the indentation is pretty odd – they are indented three spaces instead of your usual four. I think most code would not indent these at all.

[ these are very, very minor issues ]

dustinlacewell commented 1 year ago

Ah nice catch. I'll run the formatter over the whole codebase.