search

dustinlakin / twitch-rb

Twitch API gem
MIT License
51 stars 28 forks source link

Many improvements #34

Open AlexWayfer opened 4 years ago

AlexWayfer commented 4 years ago

Changes are described in CHANGELOG.md.

AlexWayfer commented 4 years ago

Oh, I forgot to push TwitchOAuth2 and make improvements for outdated tokens. Wait a moment, please.

AlexWayfer commented 4 years ago

Now it uses git-version of twitch_oauth2. I'll check these gems together in real-life project and then release twitch_oauth2.

AlexWayfer commented 4 years ago

Also I can try to replace VCR with regular RSpec allowing and expectations. I don't know why my minds were clouded by new for me technology (VCR). :sweat_smile:

AlexWayfer commented 4 years ago

No, I don't want to replace. It will looks like stubs.get('user') { [200, {}, stubbed_user] } and expect(body).to match expected_user.

So, with non-real data…

Also, Twitch documentation is incorrect. For example: https://dev.twitch.tv/docs/v5/reference/users#get-user

There is id like Integer, but in real life it's a String, and for /users/:id it's documented like a String.

So, let's move with VCR cassetes.

AlexWayfer commented 4 years ago

Done, everything looks working.

AlexWayfer commented 4 years ago

This pull request is ready.

AlexWayfer commented 2 years ago

Feel free to merge this

Unfortunately, I see no such button. Here is some mistake. BTW, Twitch closed the Kraken API.