search

dustinlakin / twitch-rb

Twitch API gem
MIT License
51 stars 28 forks source link

Split gem into multiple modules and classes. Add support for Adapters. #8

Closed mrbeardy closed 9 years ago

mrbeardy commented 9 years ago

* Works exactly the same as the previous versions (I hope), but I've moved some of the code into modules and classes for easier editing.

* Adds Adapters, which allows the gem to use different HTTP libraries (see bottom of README.md for an example that uses open-uri).

I've also added some tests for Adapters, all new and previous tests passed for me (except three; two failed since I didn't provide an access_token and the third failed due to mismatched parameters to editChannel, though I had the same test failures before making any changes).

Since this push changed a lot of code and may potentially maybe break (maybe), I've upped the version number to 0.0.5 (in twitch/version.rb), though technically I did add tests, and everyone knows tests catch 100% of the errors 99% of the time (10 times out of 7).

The gemspec should also get the version number from the version file now too, so you should just be able to update version.rb to have it update the gemspec.

dustinlakin commented 9 years ago

Thanks MrBeardy, I will work on getting a new gem up too! Cheers