search

dustinlyons / nixos-config

General purpose Nix configuration for macOS / NixOS with starter templates + step-by-step guides ✨
BSD 3-Clause "New" or "Revised" License
1.79k stars 113 forks source link

[Question] Have you considered adding a dock module to nix-darwin? #70

Closed ivankovnatsky closed 6 months ago

ivankovnatsky commented 7 months ago

Hello, you have a very nice dock module. Have you considered adding it to https://github.com/LnL7/nix-darwin? Thought it might not that straightforward: https://github.com/LnL7/nix-darwin/blob/230a197063de9287128e2c68a7a4b0cd7d0b50a7/modules/system/defaults/dock.nix#L118. But still the community will definitely benefit from it.

I was using myself pretty much imperative way: https://github.com/ivankovnatsky/nixos-config/blob/main/home/darwin.nix#L25, your module looks pretty elegant compared to that 😄

dustinlyons commented 6 months ago

Hi, thanks for the suggestion! It's actually not entirely my code, I found a gist online where someone else had described the dock in this way. It is very elegant.

Here it is: https://gist.github.com/antifuchs/10138c4d838a63c0a05e725ccd7bccdd

I think it is a good idea to contribute upstream, maybe I'll get some time at some point.