search

dustinspecker / eslint-plugin-no-use-extend-native

ESLint plugin to prevent use of extended native objects
MIT License
56 stars 4 forks source link

Updates #129

Closed brettz9 closed 4 years ago

brettz9 commented 4 years ago

Requires esm now for ava (unless were to use Node's implementation): https://github.com/avajs/ava/blob/master/docs/recipes/es-modules.md

BREAKING CHANGE:

Had not been indicating supported engine.

I wasn't sure the engine specify. While Babel might take care of the syntax, one might need to add https://github.com/mysticatea/eslint-plugin-node to check the builtins (if not using core-js). Assuming that is, you even want Babel anymore.

Note that I changed the repository to a full link not only to silence an inadequate package.json validator, but because full links can be useful in IDEs (e.g., in Atom, I can click "cmd-O" on a URL under the cursor to open it).

Planning to add a couple PRs, but thought I'd get things started here.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 9a796d7c845271c801257219775d7734db3a3a2e on brettz9:updates into 8f6fbae7d3a38fbb651366fade8a37002b680de5 on dustinspecker:master.

dustinspecker commented 4 years ago

Thank you! These are awesome! Great commits too - makes this easy to review. Yeah, I'd totally be cool with having Babel removed going forward.

brettz9 commented 4 years ago

On second thought though, since the code is currently using ESM in source, unless there is a compelling reason to switch now to Rollup (or if time passes so as to use Node ESM), maybe it is easier to leave as is?