dusty-nv / jetson-containers

Machine Learning Containers for NVIDIA Jetson and JetPack-L4T
MIT License
2.18k stars 446 forks source link

Container's directory name needs to be unique regardless of path #478

Open ms1design opened 5 months ago

ms1design commented 5 months ago

Hi @dusty-nv 👋

I've created a wyoming wrapper for existing faster-whisper container called wyoming-faster-whisper. Unfortunately, I've encountered an issue where I can't use the same container directory names even if they're in different paths. For instance:

As a result, faster-whisper is detected, but wyoming-faster-whisper is not. However, if we change its path to anything other than .../faster-whisper, it works as expected. Not sure if this was intended?

Best, M

dusty-nv commented 5 months ago

Can you try manually setting the name in the dockerfile yaml header or config.py? And yes, it gets the initial package name from the directory before parsing the dockerfile and config files


From: ms1design @.> Sent: Wednesday, April 17, 2024 11:25:54 AM To: dusty-nv/jetson-containers @.> Cc: Dustin Franklin @.>; Mention @.> Subject: [dusty-nv/jetson-containers] Container's directory name needs to be unique regardless of path (Issue #478)

Hi @dusty-nvhttps://github.com/dusty-nv 👋

I've created a wyoming wrapper for existing faster-whisper container called wyoming-faster-whisper. Unfortunately, I've encountered an issue where I can't use the same container directory names even if they're in different paths. For instance:

As a result, faster-whisper is detected, but wyoming-faster-whisper is not. However, if we change its path to anything other than .../faster-whisper, it works as expected. Not sure if this was intended?

Best, M

— Reply to this email directly, view it on GitHubhttps://github.com/dusty-nv/jetson-containers/issues/478, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADVEGK5SLVP665L3ZMMX3YDY52IAFAVCNFSM6AAAAABGLRUXH6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2DQNJXGAZDONQ. You are receiving this because you were mentioned.Message ID: @.***>

ms1design commented 5 months ago

Tried to fix that using config.py, but setting the name or alias there does nothing. Only the dir name change helps.

dusty-nv commented 5 months ago

@ms1design will look at this later, but for now just create it under wyoming/whisper . I think that should be fine anyways as we don't really wanna maintain multiple whisper variants for wyoming anyways

ms1design commented 5 months ago

That's sounds reasonable, thanks for explanations @dusty-nv 🙏

Edit: Changed the dir name to wyoming-whisper (packages/smart-home/wyoming/wyoming-whisper 👀 ) - other container names already taken :)