search

dusty-phillips / gitifyhg

Tools for using git as a client to mercurial repositories
GNU General Public License v3.0
62 stars 17 forks source link

pushing executable files and symlinks is probably broken #5

Closed fingolfin closed 11 years ago

fingolfin commented 11 years ago

... at least your code retains the bug in git-remote-hg that I fixed with this pull request: https://github.com/felipec/git/pull/14

It is kind of sad to see yet another project to solve the same problem, number 5 or 6 on my list... I hope one day we will be left with just 1-2, working together, instead of all this duplication of effort sigh.

dusty-phillips commented 11 years ago

gitifyhg 0.6.2 should incorporate your fix.

I'm not too keen on duplicate effort myself, but I was not happy with the style (globals, pep8) of the felipec git-remote-hg code. Combining a bout of free time over the holidays with my pull requests being ignored, I ended up with this rendition. I believe gitifyhg is more stable and more hackable than other solutions. I will be maintaining it as long as a) I work for YouGov and b) YouGov employees persist in belittling my pleas to switch to git.

I do hope gitifyhg becomes the project we work together on, as you recommend, but if another project comes out ahead, I'll be happy to use it.

fingolfin commented 11 years ago

Thanks for the fix!

As to my sadness about the plethora of tools: This wasn't really directed towards you or your project, just a general observation... :-(. I actually do understand why you made yet another project (myself, I am not sure whether felipe' even plans to update his git-remote-hg, nor is it always exactly pleasant to work with him).

But if I may: I'd suggest being very careful about wording when comparing these tools. Statements like "This is the most robust and usable git to hg bridge currently available" are prone to make people upset and cause misunderstandings.... Felipe had this stance, and as a result, had a falling out with the developers of msysgit remote-hg... then felipe made the same claims about his, and then you were not exactly thrilled by your experiences with his code...

Now I looked at gitifyhg, and immediately observe a serious issue... and I am pretty sure gitifyhg retains some of the other hard problems felipe's git-remote-hg suffers from -- my guess is actually that all remote helpers will suffer from some problems due to limitations of the remote-helper API (but perhaps I just misunderstand the remote helper interface).

So, what I personally take from this is that I prefer slightly more humble and reserved statements, like "This is in my experience the most robust and usable git to hg bridge I am aware of" ;-).

fingolfin commented 11 years ago

That all said, I really am glad that you are actively working on this, and hope that gitifyhg will become the tool for this purpose. But like all the others, in my perception, it still has quite a bit to go. This week alone, i was exercising it and git-remote-hg a lot -- we are on a coding marathon for an open source project, where the central repository is using hg, but several of us prefer git... after some initial eager attempts, we now all switch to first making a hg clone of the remote repo, then make a git clone of that, and to never attempt to directly push to the remote repo; rather, we push to the local hg repo, then inspect stuff there, and only then push to the remote repo. Else, too much breakage creeps into the remote repo. So, again, i think these tools all need to mature a lot more. But you are working on that, it seems, and I appreciate that a lot!