search

dusty-phillips / gitifyhg

Tools for using git as a client to mercurial repositories
GNU General Public License v3.0
62 stars 17 forks source link

Store all marks as sha1s instead of integer local revisions. #51

Closed dusty-phillips closed 11 years ago

dusty-phillips commented 11 years ago

This should help with quite a few future advanced endeavors and make the entire app more stable in the long run. Most of the related complaints are referenced from issue #16.

The test suite is passing with all of these, but I'd like some additional testing in the real world and feedback before I merge it into master.

I thought this was going to warrant a major release, but the changes turned out to be pretty minor. Hopefully, however, we can leverage them for some of the other problems. Then again, I may be missing something. This is one of those "I wrote it in an airplane" commits. ;-)

Jed, Max, any comments?

jedbrown commented 11 years ago

Awesome work, I love that it turned out to be simpler code too. Unfortunately, I don't think this can be merged without a major new release and loud warnings unless it is extended to transparently upgrade the marks files. But that should be easy, right? If marks-hg is in the old format (integer marks), then once you have opened the hg repository, just translate all the integers to sha1s by looping through HGMarks.revisions_to_marks/HGMarks.marks_to_revisions.

dusty-phillips commented 11 years ago

Yeah, I was planning to release a 0.8 with a warning that it would blow up on invalid marks. The translation process is trivial though, as you say. It wouldn't be hard to either include a script or even run it on the fly. If I get a chance, I'll have a look at that.

Before making a release, I'd like to refactor gitifyhg.py into a package, as it's getting too long for one file. I'm hoping to do this before pycon, as I'll be advertising it a bit there.

fingolfin commented 11 years ago

Sorry folks, been busy so I could not yet look at the patch. At this time I'm heavily using gitifyhg, so I would strongly prefer the ability to auto-upgrade an existing clone on the fly.

More comments perhaps tomorrow...

Max

Am 09.03.2013 um 00:44 schrieb Dusty Phillips notifications@github.com:

Yeah, I was planning to release a 0.8 with a warning that it would blow up on invalid marks. The translation process is trivial though, as you say. It wouldn't be hard to either include a script or even run it on the fly. If I get a chance, I'll have a look at that.

Before making a release, I'd like to refactor gitifyhg.py into a package, as it's getting too long for one file. I'm hoping to do this before pycon, as I'll be advertising it a bit there.

— Reply to this email directly or view it on GitHub.