search

dusty-phillips / gitifyhg

Tools for using git as a client to mercurial repositories
GNU General Public License v3.0
62 stars 17 forks source link

Transparently upgrade marks-hg from integer revision to SHA1, closes #16 #52

Closed jedbrown closed 11 years ago

jedbrown commented 11 years ago

This extends pull request #51

dusty-phillips commented 11 years ago

Sweet! I had started on this but ran out of time. Would you be able to add a unit test?

Sent with AquaMail for Android http://www.aqua-mail.com

On March 9, 2013 12:37:20 PM Jed Brown notifications@github.com wrote:

This extends pull request #51 You can merge this Pull Request by running:

git pull https://github.com/jedbrown/gitifyhg hgshamarks

Or you can view, comment on it, or merge it online at:

https://github.com/buchuki/gitifyhg/pull/52

-- Commit Summary --

  • Transparently upgrade marks-hg from integer revision to SHA1, closes #16

-- File Changes --

M gitifyhg.py (17)

-- Patch Links --

https://github.com/buchuki/gitifyhg/pull/52.patch https://github.com/buchuki/gitifyhg/pull/52.diff

jedbrown commented 11 years ago

It would be more complexity to maintain support for writing new marks files in the old format, thus any test would need a repository created with an old gitifyhg. As much as I hate untested code, this conversion is very simple and I've been using it on several of my repositories.