search

dusty-phillips / gitifyhg

Tools for using git as a client to mercurial repositories
GNU General Public License v3.0
62 stars 17 forks source link

Prettier git messages and another big refactor of ref parsing #65

Closed alexsydell closed 11 years ago

dusty-phillips commented 11 years ago

Hi Alex,

Thanks for the work. I like most of these changes, but I'm having trouble reviewing them due to the large commits (this is probably because I haven't spent enough time at it). Can you break them up into logical changesets? My mantra is generally "one idea per commit" with an additional axiom of "a commit message should never contain the word 'and'".

If not, I'll put more effort into reviewing them, hopefully later this week.

alexsydell commented 11 years ago

Hey Dusty, I think they're about as broken up as they can be. Are you looking at the commits individually, or at the whole pull request? While the pull request contains the word 'and', the individual commits don't (well, technically one does, but not because it has separate ideas in it) :) I thought about making separate pull requests, but it seemed a bit strange since the second would build a lot on the first.

The first commit is largeish but is mostly renaming and moving stuff around, so it should be a pretty easy review. The second is a lot smaller and is based around the idea of adding the current hash to each ref instead of reporting it as "?". Let me know if I can help describe or fix anything else that doesn't make sense.